Conversation
Member
|
This is great but but looks like some unrelated whitespace changes slipped in too. |
plafosse
approved these changes
Jan 9, 2026
Contributor
Author
Not sure if it's what you're referring to, but the changes in platform_linux.cpp are updating code that was using a deprecated API to use the replacement. |
bdash
force-pushed
the
test_cpp_deprecated_attr
branch
from
9ccb29d to
c2e9d5d
Compare
A `BN_DEPRECATED` macro is introduced that expands to a `[[deprecated(msg)]]` attribute. Using functions that are annotated as deprecated will generate a compiler warning. This should help make users aware that they should migrate to replacement APIs.
bdash
force-pushed
the
test_cpp_deprecated_attr
branch
from
c2e9d5d to
45ecf56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
BN_DEPRECATEDmacro is introduced that expands to a[[deprecated(msg)]]attribute. Using functions that are annotated as deprecated will generate a compiler warning. This should help make users aware that they should migrate to replacement APIs, making it safer for us to remove the deprecated APIs in a future release.Fixes #7802.